This repository was archived by the owner on Feb 13, 2022. It is now read-only.
handle_get() to truncate data on last "\nEND\n" #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searching the buffer string for "END" causes problems if the data inside contains the substring "END". For example, if I retrieve the string "Please do not EXTEND beyond the edge" from my memcached server, the "END" in EXTEND will signal the end of the data, and only "Please do Not E" will be returned. This is fixed by looking for ``crlf + "END" + crlf``. On the off chance that the data contains that string, it is advisable to search for the last occurrence of it, instead of the first.
lib/memcache.js
Outdated
Author
There was a problem hiding this comment.
From what I can tell, there is no way to retrieve multiple values with a single get request, so looking for the last instance of crlf + "END" + crlf should be fine. However, if I am misinterpreting, and the code needs to be able to handle multiple VALUE...END pieces, let me know and I will change lastIndexOf() to indexOf()
Author
|
Hi Elbart, Thank you for making the node-memcache module! This is my first pull-request to someone else's code, so please let me know how I did, and if there is anything else I can do to make my simple change better. |
Based on other pull requests to node-memcache that solve the same problem
|
@dylancwood See #46 for a better approach |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching the buffer string for "END" causes problems if the data inside contains the substring "END". For example, if I retrieve the string "Please do not EXTEND beyond the edge" from my memcached server, the "END" in EXTEND will signal the end of the data, and only "Please do Not E" will be returned. This is fixed by looking for
crlf + "END" + crlf. On the off chance that the data contains that string, it is advisable to search for the last occurrence of it, instead of the first.From what I can tell, there is no way to retrieve multiple values with a single get request, so looking for the last instance of
crlf + "END" + crlfshould be fine. However, if I am misinterpreting, and the code needs to be able to handle multiple VALUE...END pieces, let me know and I will change lastIndexOf() to indexOf()