Materialize shape into an ETS table #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnetised
force-pushed
the
materialize-shape
branch
2 times, most recently
from
160f2f0 to
9bf7897
Compare
thruflo
reviewed
Aug 11, 2025
| This allows you to subscribe to the shape and receive notifications and | ||
| also retrieve the current dataset. | ||
|
|
||
| `to_list/2` will return the current state of the shape as a list: |
Contributor
There was a problem hiding this comment.
Experience from working with shapes and collections tells me that to_list is one way you may want the data but having map access, keyed on the ID, is also very helpful. Could you provide has, get, etc.? Or even implement Enumerable? How convenient can we make the data access?
Contributor
Author
There was a problem hiding this comment.
Makes sense. I've added a stream/1,2 function that returns a lazy stream of the data as well as to_map/1,2
I've also added find/3 as a wrapper around stream/1 to simplify finding values in the collection -- I think this is as close to get as we're going to get without going through to_map.
magnetised
force-pushed
the
materialize-shape
branch
from
1807c16 to
e6d1b28
Compare
thruflo
approved these changes
Aug 13, 2025
that emits sync events from updates within a sandboxed transaction
increase timeout for receive
magnetised
force-pushed
the
materialize-shape
branch
from
96a6025 to
ee26ff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58