build: patch out lerna for verdaccio publish#4185
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
erikian
approved these changes
Mar 21, 2026
Member
erikian
left a comment
erikian
left a comment
There was a problem hiding this comment.
I wonder if this can be upstreamed? There doesn't seem to be any opposition to this feature in the linked issue, so it might be worth a shot.
Member
Author
|
Yep, I was hoping on landing this first as a proof of concept before opening a PR upstream :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a patch to add a
--skip-check-working-treeflag to Lerna Publish so that you can runyarn test:verdaccioeven with a dirty git working tree.On the way, I upgrade Lerna versions to the latest that our age gate allows.
ref lerna/lerna#2329
Testing
yarn test:verdacciowith uncommitted changes. This should publish packages to the Verdaccio registry and run your tests.--skip-check-working-treeflag inspawn-verdaccio.tsand try running the same tests. This should fail pretty quickly on thelerna publishstep.