fix: fix outlined button styles and improve their accessibility#1002
fix: fix outlined button styles and improve their accessibility#1002dsanders11 merged 5 commits intoelectron:mainfrom
Conversation
| // Docusaurus adds its own focus styles which we need to | ||
| // override here to avoid losing the outline. | ||
| // ref: https://github.com/electron/website/issues/1001 | ||
| body:not(.navigation-with-keyboard) &--outline:focus { |
There was a problem hiding this comment.
This isn't ideal, but Docusaurus is too board in their approach to hiding focus outlines when the user is using a mouse (I added a comment here in this issue to get the attention of their team: facebook/docusaurus#11314 (comment))
There was a problem hiding this comment.
The hook that requires this funky CSS by us has been removed upstream in Docusaurus (facebook/docusaurus#11713), but no new version has been released yet.
dsanders11
left a comment
dsanders11
left a comment
There was a problem hiding this comment.
Thanks for fixing this upstream as well! Since Docusaurus tends to release infrequently, I'll merge this now (I added the upstream PR as additional context in the comment) and we'll revert this change once we pick up the upstream change.
|
@nmggithub, looks like the linter is unhappy here, could you run |
Just did it! Thanks for letting me know. |
2 participants
Description of Change
Fixes #1001.
Checklist