Skip to content

Workaround for crashing when many tooltips are shown consecutively #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flodavid wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −4
Open

Workaround for crashing when many tooltips are shown consecutively #563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions src/AppSystem/Launcher.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public class Dock.Launcher : BaseItem {
private uint queue_dnd_cycle_id = 0;

private bool flagged_for_removal = false;
private bool waiting_to_open_tooltip = false;

public Launcher (App app) {
Object (app: app, group: Group.LAUNCHER);
Expand Down Expand Up @@ -246,11 +247,12 @@ public class Dock.Launcher : BaseItem {

var motion_controller = new Gtk.EventControllerMotion ();
motion_controller.enter.connect (() => {
if (!popover_menu.visible) {
popover_tooltip.popup ();
}
this.wait_and_show_tooltip (100);
});
motion_controller.leave.connect (() => {
this.waiting_to_open_tooltip = false;
if (popover_tooltip.visible) popover_tooltip.popdown ();
});

add_controller (motion_controller);

var scroll_controller = new Gtk.EventControllerScroll (VERTICAL);
Expand Down Expand Up @@ -486,4 +488,23 @@ public class Dock.Launcher : BaseItem {
multiple_windows_open = app.windows.length > 1;
}
}

private void wait_and_show_tooltip (uint delay_ms) {
if (!popover_menu.visible) {
// Add timeout to avoid "Error 71 (Protocol error) dispatching to Wayland display".
// This error is probably caused by a bug in GTK caused by the Nvidia driver at least up to v580.
// Documented in issue #559 on the Github project.
waiting_to_open_tooltip = true;
GLib.Timeout.add (delay_ms, () => {
if (waiting_to_open_tooltip) {
waiting_to_open_tooltip = false;
if (!popover_menu.visible) {
popover_tooltip.popup ();
}
}

return false;
});
}
}
}