AppMenu: use settings action for date format#2729
Draft
danirabbit wants to merge 3 commits intomainfrom
Draft
Conversation
jeremypw
requested changes
Feb 11, 2026
Contributor
jeremypw
left a comment
There was a problem hiding this comment.
If you change the settings directly with e.g. dconf-editor then you get an infinite loop either on the first attempt or subsequent one. Not sure if this is due to these changes (which otherwise look very good) but be nice to fix it anyway.
Member
Author
|
Hm yeah. This appears to have something to do with setting the group. It looks like it's not necessary to do in GTK4, but for some reason we don't get the right styles in GTK3. Might have to wait until after the port |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
groupproperty instead offrom_widgetsince this will go away in GTK4