Skip to content

AppMenu: use settings action for date format#2729

Draft
danirabbit wants to merge 3 commits intomainfrom
danirabbit/appmenu-dateformat-action
Draft

AppMenu: use settings action for date format#2729
danirabbit wants to merge 3 commits intomainfrom
danirabbit/appmenu-dateformat-action

Conversation

@danirabbit
Copy link
Member

  • It's not recommended to connect to "toggled", we should use actions instead
  • Also use group property instead of from_widget since this will go away in GTK4

@danirabbit danirabbit requested a review from a team February 10, 2026 16:45
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the settings directly with e.g. dconf-editor then you get an infinite loop either on the first attempt or subsequent one. Not sure if this is due to these changes (which otherwise look very good) but be nice to fix it anyway.

@danirabbit danirabbit marked this pull request as draft February 11, 2026 23:27
@danirabbit
Copy link
Member Author

Hm yeah. This appears to have something to do with setting the group. It looks like it's not necessary to do in GTK4, but for some reason we don't get the right styles in GTK3. Might have to wait until after the port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants