Add zoom actions to abstract directory view#2743
Draft
danirabbit wants to merge 8 commits intomainfrom
Draft
Conversation
# Conflicts resolved: # src/View/AbstractDirectoryView.vala # src/View/Window.vala
Contributor
|
@danirabbit There were some typos that prevented the zoom actions working as expected - I fixed. Now you just need to get the accelerators working as before. |
Member
Author
|
I fixed accels, but its now very complicated and feels icky. Maybe this isn't the right direction for where these should live 🤔 |
Contributor
|
I agree. Maybe the toplevel window is the best place after all? Or somewhere you do not need different actions for different viewmodes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should theoretically allow us to clean up a bunch of the zoom handling and let abstract directory view do all of the heavy lifting