Skip to content

AbstractDirectoryView: get thumbnail settings from gsettings#2747

Merged
jeremypw merged 6 commits intomainfrom
danirabbit/preferences-rmthumbnails
Feb 14, 2026
Merged

AbstractDirectoryView: get thumbnail settings from gsettings#2747
jeremypw merged 6 commits intomainfrom
danirabbit/preferences-rmthumbnails

Conversation

@danirabbit
Copy link
Member

No description provided.

@danirabbit danirabbit requested a review from a team February 12, 2026 16:45
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toggling the setting in the AppMenu does not cause the view to update its thumbnails.

@danirabbit danirabbit requested a review from jeremypw February 12, 2026 18:57
@danirabbit
Copy link
Member Author

@jeremypw should be fixed, sorry!

@jeremypw
Copy link
Contributor

@danirabbit Could you resolve conflict please?

@danirabbit
Copy link
Member Author

@jeremypw done!

Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly works now although there is a strange issue with remote thumbnails on an FTP server (maybe pre-existing - I'll check). When you navigate to a folder containing thumbnailable files immediately after logging on to the server, then whether thumbnails are shown depends on the local setting not the remote setting. However, if either the settings are then toggled on and off then the correct view is obtained.

@jeremypw
Copy link
Contributor

Just confirmed that bug is present in main so will approve this.

@jeremypw jeremypw merged commit 24bebed into main Feb 14, 2026
4 checks passed
@jeremypw jeremypw deleted the danirabbit/preferences-rmthumbnails branch February 14, 2026 19:32
@jeremypw
Copy link
Contributor

Looks like a similar issue was reported some time ago - #2341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants