Skip to content

AbstractDirectoryView: rewrite SortSubMenu using GLib.Menu#2756

Merged
jeremypw merged 2 commits intomainfrom
danirabbit/abstractdirectoryview-sortsubglibmenu
Feb 15, 2026
Merged

AbstractDirectoryView: rewrite SortSubMenu using GLib.Menu#2756
jeremypw merged 2 commits intomainfrom
danirabbit/abstractdirectoryview-sortsubglibmenu

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 13, 2026

No Gtk.MenuItem in GTK4. Port this section over to using a GLib.Menu

@danirabbit danirabbit requested a review from a team February 13, 2026 18:33
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Feb 13, 2026
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and no regressions found

@jeremypw jeremypw merged commit 6c5e657 into main Feb 15, 2026
4 checks passed
@jeremypw jeremypw deleted the danirabbit/abstractdirectoryview-sortsubglibmenu branch February 15, 2026 17:02
@github-project-automation github-project-automation bot moved this from Needs Review to Done in GTK4 Porting Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants