Add theme variant support #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added config option to disable searchable iniswap Making it editable is fine but it makes it a lot more annoying to click on it as a result.
Various iniswap dropdown improvements
Add action to also build master merged onto PR.
Reworked logger to be faster and safe
Project restructure
…ng each others under a cursor
…hub.com/Chrezm/DRO-Client into nonum/optimize-empty-trivial-characters
…load Allow character list reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements theme variants. A theme variant is created inside a theme folder as a subfolder with a name (the 'variant name'). If the client is requested to switch to that theme variant (either by a temporary client OOC command, or a server-sent "VA" packet), it will load that theme variant. What that means is that, for each file the theme will attempt to load or use when the theme is reloaded, it will first check in the variant's folder to see if the file it is looking for there exists there. If so, it will use that file in the variant folder. Otherwise, it will use the one from the theme folder. If the variant folder does not exist at all, the client will just use the theme folder files. Both the /variant OOC command and receiving the "VA" packet will immediately set the theme variant.
Additional changes were included that make the client fall back to contents from a 'default' theme if it exists in case a particular file is not found in either the variant folder or the theme folder.
More code cleanup was made.