New functions: uninstall(), is_installed() #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus some minor changes: - added unittests to test reset() functionality - fixed a minor bug in __init__.py where py2 module was import first when running on py3 - prevent pyc files from being written during unittests, to protect later tests from finding pyc files written by earlier tests NOTE: reset() and uninstall() don't fully work in py2, and their tests currently fail on py2, until issue#2 is resolved (elfsternberg#2)
elfsternberg
approved these changes
Dec 3, 2016
Owner
elfsternberg
left a comment
elfsternberg
left a comment
There was a problem hiding this comment.
Good work. I'm not happing with elif; I think it's a bad semantic that Python shouldn't have adopted, but oh well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some minor changes:
NOTE: reset() and uninstall() don't fully work in py2, and their tests currently fail on py2,
until issue#2 is resolved (#2)