fix: handle ellipsis before <-, ::, and when#114
Open
mkaput wants to merge 1 commit intoelixir-tools:mainfrom
Open
fix: handle ellipsis before <-, ::, and when#114mkaput wants to merge 1 commit intoelixir-tools:mainfrom
mkaput wants to merge 1 commit intoelixir-tools:mainfrom
Conversation
mkaput
force-pushed
the
mk/pr-8b50284-ellipsis-ops
branch
from
f378b07 to
065ec79
Compare
Ellipsis standalone detection used is_binary_op?/1, but that set did not include in_match_op, type_op, or when_op. As a result, expressions like x...<-y and x...::y attempted to parse <-/:: as an ellipsis RHS prefix and failed with unknown token errors. Extend @binary_op_types with when_op, in_match_op, and type_op so parse_ellipsis_op/1 keeps ... standalone before those operators, matching Elixir AST behavior. Add regression assertions in the existing property regression block for x...<-y, x...::y, and x... when y alongside the newline ternary case.
mkaput
force-pushed
the
mk/pr-8b50284-ellipsis-ops
branch
from
065ec79 to
caa2ffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ellipsis standalone detection used is_binary_op?/1, but that set did not include in_match_op, type_op, or when_op. As a result, expressions like x...<-y and x...::y attempted to parse <-/:: as an ellipsis RHS prefix and failed with unknown token errors.
Extend @binary_op_types with when_op, in_match_op, and type_op so parse_ellipsis_op/1 keeps ... standalone before those operators, matching Elixir AST behavior.
Add regression assertions in the existing property regression block for x...<-y, x...::y, and x... when y alongside the newline ternary case.