Skip to content

test: unify parsing assertions #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkaput wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: unify parsing assertions #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66f5967
refactor(test): unify parsing assertions
mkaput Feb 19, 2026
aeda023
refactor(test): use Spitfire.Assertions in conformance_test.exs
mkaput Feb 19, 2026
6d8fa20
refactor(test): use Spitfire.Assertions in operators_test.exs
mkaput Feb 19, 2026
a7d61db
refactor(test): use Spitfire.Assertions in spitfire_test.exs
mkaput Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 2 additions & 45 deletions test/conformance_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ defmodule Spitfire.ConformanceTest do
"""
use ExUnit.Case, async: true

import Spitfire.Assertions, only: [assert_conforms: 1]

# =============================================================================
# TERMINALS - Basic building blocks that are valid as standalone expressions
# =============================================================================
Expand Down Expand Up @@ -2895,49 +2897,4 @@ defmodule Spitfire.ConformanceTest do
assert_conforms("^!u\n;")
assert_conforms("foo()\n;")
end

# =============================================================================
# Helper function
# =============================================================================

defp assert_conforms(code, _opts \\ []) do
reference = s2q(code)

case reference do
{:ok, expected_ast} ->
actual = spitfire_parse(code)

assert actual == reference,
"""
AST mismatch for: #{inspect(code)}

Reference:
#{inspect(expected_ast, pretty: true)}

Actual:
#{inspect(actual, pretty: true)}
"""

{:error, _} ->
# Reference parser errors - skip, nothing to validate conformance against
:ok
end
end

defp s2q(code) do
Code.string_to_quoted(
code,
columns: true,
token_metadata: true,
emit_warnings: false
)
end

defp spitfire_parse(code) do
case Spitfire.parse(code) do
{:ok, ast} -> {:ok, ast}
{:error, _ast, _errors} -> {:error, :parse_error}
{:error, :no_fuel_remaining} -> {:error, :no_fuel_remaining}
end
end
end
Loading
Loading