fix: preserve leading nil in stab clause body#120
Open
mkaput wants to merge 1 commit intoelixir-tools:mainfrom
Open
fix: preserve leading nil in stab clause body#120mkaput wants to merge 1 commit intoelixir-tools:mainfrom
mkaput wants to merge 1 commit intoelixir-tools:mainfrom
Conversation
A -> clause body can begin with a semicolon token after optional newlines, and that semicolon represents an implicit leading nil expression in the clause rhs. The previous detection logic did not recognize the `-> \n;expr` shape reliably, so the resulting AST dropped that leading nil and diverged from Code.string_to_quoted/2 output in with ... else clauses. This change detects the leading semicolon by peeking past end-of-line trivia before consuming clause eoe tokens, preserving the expected rhs shape. A regression assertion was added to `property test regression cases` for `with x <- 1 do :ok else _ -> \n;a end` to prevent this AST mismatch from returning. fix elixir-tools#113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A -> clause body can begin with a semicolon token after optional newlines, and that semicolon represents an implicit leading nil expression in the clause rhs.
The previous detection logic did not recognize the
-> \n;exprshape reliably, so the resulting AST dropped that leading nil and diverged from Code.string_to_quoted/2 output in with ... else clauses.This change detects the leading semicolon by peeking past end-of-line trivia before consuming clause eoe tokens, preserving the expected rhs shape.
A regression assertion was added to
property test regression casesforwith x <- 1 do :ok else _ -> \n;a endto prevent this AST mismatch from returning.fix #113