Implement filename parsing from reply headers#155
Merged
Conversation
achempion
force-pushed
the
content-disposition
branch
from
July 16, 2026 11:33
c1bda72 to
3003a2e
Compare
klacointe
reviewed
Jul 16, 2026
Comment on lines
+103
to
+106
| case decode_extended_value(value) do | ||
| {:ok, filename} -> filename | ||
| :error -> nil | ||
| end |
Contributor
There was a problem hiding this comment.
It misses case when :unicode.characters_to_binary(value, :latin1, :utf8) in decode_charset/2 returns error or incomplete ? https://www.erlang.org/doc/apps/stdlib/unicode.html#characters_to_list/2
Member
Author
There was a problem hiding this comment.
can you please give an example with a failing test case?
Contributor
There was a problem hiding this comment.
You fixed it in the last force-push 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context
related #154