Speed optimizations for poseidon2_goldilocks_plonky2 and field.#34
Open
Mychecksdead wants to merge 13 commits intomainfrom
Open
Speed optimizations for poseidon2_goldilocks_plonky2 and field.#34Mychecksdead wants to merge 13 commits intomainfrom
Mychecksdead wants to merge 13 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed + memory optimizations.
Speed:
branchHints as they aren't working.externalLayerfunction (reordering of calculations, manual inlining).Memory:
Created
HashNToMNoPadBytesOptimized. This new function assumes a 32-byte output array as parameter.Similarly updated
Sumfunction.Directly used
bits.LittleEndian.PutUint64function to avoidmake()insideToLittleEndianBytes.Added tests.
Simple changes in
uint128for simplicity.