Add missing imports in documentation#233
Closed
jfmengels wants to merge 2 commits intoelm-explorations:masterfrom
Closed
Add missing imports in documentation#233jfmengels wants to merge 2 commits intoelm-explorations:masterfrom
jfmengels wants to merge 2 commits intoelm-explorations:masterfrom
Conversation
lue-bird
approved these changes
Feb 22, 2024
Collaborator
|
Thanks Jeroen!
Yeah that would be nice! |
Collaborator
|
Let's keep Test.Html.Query for some other day 👍 |
Collaborator
|
Your other PR #242 made this PR redundant - closing because there's nothing in the diff anymore :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed a few missing imports in the examples.
A few notes: The imports are not sorted the way that
elm-formatsorts them. Would you like to see this be done as well?I've only done it for this module, but I've seen some examples in
Test.Html.Querywhere imports are missing and/or lead to confusion and invalid code. (See for instanceTest.Html.Query.keepwheretextis used from bothHtmlandTest.Html.Selector, and similarlyTest.Html.Query.childrenusesclassin the same invalid way). Let me know if you want me to solve this (and if so, indicate how you would prefer to see these collisions resolved). Maybe other modules have import issues, I haven't looked at it yet.