Support classes set using the class attribute#247
Merged
Janiczek merged 3 commits intoelm-explorations:masterfrom Jan 30, 2026
Merged
Support classes set using the class attribute#247Janiczek merged 3 commits intoelm-explorations:masterfrom
class attribute#247Janiczek merged 3 commits intoelm-explorations:masterfrom
Conversation
Janiczek
reviewed
Jan 29, 2026
Collaborator
There was a problem hiding this comment.
Started looking at this. I had a go at trying to trickle down Result String from this classnames function but it got too much too quickly.
I'm contemplating making a validation pass of the parsed HTML during decoding of the HTML before running other queries (failing early if we find this mixing of class and className). If that doesn't seem simple enough, I'll likely merge this as-is.
I'm also contemplating having a bit of mutable state (via kernel JS) holding a flag "classnames found this collision" that we could show a warning about later, but that feels quite icky...
Collaborator
|
Thanks for your work on this @lydell, this is now live in 2.2.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #246