Add WebGL.Texture.loadBytesWith#13
Open
justgook wants to merge 1 commit intoelm-explorations:mainfrom
Open
Conversation
Zinggi
reviewed
May 14, 2019
|
I think much of the js/Kernel code in this PR could be moved into pure elm without any performance cost. Having less kernel code might increase the chances of this PR getting accepted. In particular, an elm implementation of |
5de8961 to
e9e1c15
Compare
90bf628 to
ac4f736
Compare
|
Would be nice to have this merged, if the issues have been fixed 🙂 |
Collaborator
|
Oh I see, so Evan needs to approve anything beyond patches. |
Collaborator
|
@Herteby my understanding is that the same rules apply for this package, as for any other browser integrations and changes to the core elm packages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding ability to create textures out of bytes, this is task less api, for future it will allow as create custom image / scene format loaders, create default texture without waiting for task.