-
Notifications
You must be signed in to change notification settings - Fork 10
fix occasional errors we see when generating a uuid using uuid library by switching to securerandom #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iiilx
wants to merge
9
commits into
emailage:master
Choose a base branch
from
Gusto:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix occasional errors we see when generating a uuid using uuid library by switching to securerandom #7
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bd46608
Merge pull request #1 from emailage/master
iiilx ae615bf
fix occasional errors we see when generating a uuid using uuid librar…
iiilx 1df5a81
Merge pull request #2 from Gusto/benl-fix_uuid_nomethod_error
iiilx b0ec452
raise TemporaryError if we do not receive a 200 response code and the…
iiilx 4acd049
Merge pull request #4 from Gusto/benl-temp_erroy
iiilx 287f0dc
Add customised exception if response is empty from emailage.
BharathMylarappa ee08d51
Merge pull request #6 from Gusto/bm-emailage-fix
BharathMylarappa 7c430a4
Log body if emailage api returns no json body
vaidarnav c7cb90c
Merge pull request #7 from Gusto/av-emailage-error-1
vaidarnav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 2.7.4 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,4 +19,5 @@ module Emailage | |
| } | ||
|
|
||
| class Error < StandardError; end | ||
| class Failure < StandardError; end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iiilx should remove this file, or at least put it to latest version of Ruby