Skip to content

Remove debug printfs from benchmarks#152

Open
mtdudek wants to merge 2 commits into
embench:masterfrom
mtdudek:md5sum-fix
Open

Remove debug printfs from benchmarks#152
mtdudek wants to merge 2 commits into
embench:masterfrom
mtdudek:md5sum-fix

Conversation

@mtdudek

@mtdudek mtdudek commented Nov 12, 2021

Copy link
Copy Markdown

This commit removes printfs from md5sum test, as they can influence test results.
Signed-off-by: Maciej Dudek mdudek@antmicro.com

Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
@jeremybennett

Copy link
Copy Markdown
Collaborator

@mtdudek Thanks for picking this up. There should be no external library calls in the benchmark.

I'd rather just remove this code. The danger with #define is that users will define them on the command line and we'll get invalid results. Are you happy to make this change?

Added @PaoloS02 as a second reviewer.

Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
@mtdudek

mtdudek commented Nov 15, 2021

Copy link
Copy Markdown
Author

I've removed printfs from benchmarks' bodies.

@mtdudek mtdudek changed the title Remove debug printfs from md5sum Remove debug printfs from benchmarks Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants