Updating modal to allow bindable fade and backdrop#139
Open
drewcovi wants to merge 3 commits intoember-addons:masterfrom
Open
Updating modal to allow bindable fade and backdrop#139drewcovi wants to merge 3 commits intoember-addons:masterfrom
drewcovi wants to merge 3 commits intoember-addons:masterfrom
Conversation
Author
There was a problem hiding this comment.
This seemed to be a small bug wherein the isAriaHidden was returning the opposite of the visual state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update does require the built-in bootstrap.js but it seems to make more sense than re-creating existing functionality. it also allows you to listen for the various namespaced bs events (using an eventManager)
apologies if this has been discussed elsewhere, but I'm not sure why this collection doesn't leverage the bootstrap.js libraries. These are often included anyway to ensure UI elements are working.