Better vite support #1489
Merged
Better vite support #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only ember-cli-style compat module loading understands that `test-support` imports actually pull from `addon-test-support`. So as long as we're still publishing this so that the code is in `addon-test-support`, we need to: 1. Not have any code internally import from `ember-exam/test-support` (so I replaced the one import that was doing that with a relative import that works in all cases) 2. Instruct modern (vite) consumers to import from `ember-exam/addon-test-support` (so I updated the README accordingly)
NullVoxPopuli
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix & documentation for non-ember-cli consumers, and types!