Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
2 changes: 0 additions & 2 deletions bin/changelog.cjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#!/usr/bin/env node

/* eslint-disable no-console */

'use strict';
Expand Down
1 change: 0 additions & 1 deletion lib/index.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ const shim = addonV1Shim(path.join(__dirname, '..'), {
'./dist/dev/packages/ember/version.js',
'./dist/dev/packages/route-recognizer/index.js',
'./dist/dev/packages/router_js/index.js',
'./dist/dev/packages/rsvp/index.js',
].map((x) => (isProduction ? x.replace('/dist/dev/', '/dist/prod/') : x)),
'implicit-test-modules': [
'./dist/dev/packages/ember-testing/index.js',
Expand Down
316 changes: 315 additions & 1 deletion package.json

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ packages:
- 'packages/*/*/test'
- 'smoke-tests/*'
- 'tests/*'

patchedDependencies:
ember-cli@6.12.0: patches/ember-cli@6.12.0.patch
8 changes: 4 additions & 4 deletions rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ function rolledUpPackages() {
export function exposedDependencies() {
return {
'backburner.js': require.resolve('backburner.js/dist/es6/backburner.js'),
rsvp: require.resolve('rsvp/lib/rsvp.js'),
'dag-map': require.resolve('dag-map/dag-map.js'),
router_js: require.resolve('router_js'),
'route-recognizer': require.resolve('route-recognizer/dist/route-recognizer.es.js'),
Expand Down Expand Up @@ -426,6 +425,10 @@ export function resolvePackages(deps, params) {
return { external: true, id: pkgName };
}

if (pkgName === 'rsvp') {
return { external: true, id: pkgName };
}

if (isExternal?.(source)) {
return { external: true, id: source };
}
Expand Down Expand Up @@ -550,9 +553,6 @@ function packageMeta() {
}

const allowedCycles = [
// external and not causing problems
'node_modules/rsvp/lib/rsvp',

// TODO: these would be good to fix once they're in this repo
'packages/@glimmer/debug',
'packages/@glimmer/runtime',
Expand Down
4 changes: 2 additions & 2 deletions smoke-tests/app-template/eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ export default [
'**/*.cjs',
'config/**/*.js',
'tests/dummy/config/**/*.js',
'testem.js',
'testem*.js',
'testem.*',
'testem*.*',
'index.js',
'.prettierrc.js',
'.stylelintrc.js',
Expand Down
14 changes: 14 additions & 0 deletions smoke-tests/v2-app-hello-world-template/vite.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,20 @@ import { extensions, ember } from '@embroider/vite';
import { babel } from '@rollup/plugin-babel';

export default defineConfig({
build: {
rolldownOptions: {
treeshake: {
moduleSideEffects: [
{ test: /\.css$/, sideEffects: true },
{ test: /@ember/, sideEffects: false, external: false },
{ test: /router_js/, sideEffects: false, external: false },
{ test: /rsvp/, sideEffects: false, external: false },
{ test: /backburner/, sideEffects: false, external: false },
],

}
}
},
plugins: [
ember(),
babel({
Expand Down
Loading