[BUGFIX] Fix query param redirects during active transitions#21410
Open
olenderhub wants to merge 1 commit into
Open
[BUGFIX] Fix query param redirects during active transitions#21410olenderhub wants to merge 1 commit into
olenderhub wants to merge 1 commit into
Conversation
3ac87f1 to
926018d
Compare
Contributor
|
should #21412 be looked at first? does order matter? |
Contributor
Author
|
@NullVoxPopuli It seems to me that this doesn’t really matter for this PR, so it can be checked independently. It’s a similar issue, but not the same one, in my opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes redirecting from
beforeModelto the same route with updated query params.When a query-param-only transition was started during an active transition, the router used the query-param-only path. That could lose the updated query params from the URL or crash during direct visits.
This change avoids the query-param-only path while another transition is active, allowing the normal transition path to abort and replace the active transition.
Adds regression coverage for:
Testing
pnpm test:wipFixes #18577
Refs #19609