Skip to content

compare url attribute names case-insensitively when sanitizing #21434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NullVoxPopuli wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

compare url attribute names case-insensitively when sanitizing #21434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/@glimmer-workspace/integration-tests/test/attributes-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,18 @@ export class AttributesTests extends RenderTest {
this.assertHTML('<svg viewBox="0 0 100 100" />');
this.assertStableNodes();
}

@test
'sanitizes url attributes regardless of attribute name case'() {
this.render('<a HREF={{this.foo}}></a>', { foo: 'javascript:foo()' });
this.assertHTML('<a href="unsafe:javascript:foo()"></a>');

this.rerender({ foo: 'http://foo.bar' });
this.assertHTML('<a href="http://foo.bar"></a>');

this.rerender({ foo: 'javascript:foo()' });
this.assertHTML('<a href="unsafe:javascript:foo()"></a>');
}
}

jitSuite(AttributesTests);
Expand Down
4 changes: 2 additions & 2 deletions packages/@glimmer/runtime/lib/dom/sanitized-values.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ function has(array: Array<string>, item: string): boolean {
}

function checkURI(tagName: Nullable<string>, attribute: string): boolean {
return (tagName === null || has(badTags, tagName)) && has(badAttributes, attribute);
return (tagName === null || has(badTags, tagName)) && has(badAttributes, attribute.toLowerCase());
}

function checkDataURI(tagName: Nullable<string>, attribute: string): boolean {
if (tagName === null) return false;
return has(badTagsForDataURI, tagName) && has(badAttributesForDataURI, attribute);
return has(badTagsForDataURI, tagName) && has(badAttributesForDataURI, attribute.toLowerCase());
}

export function requiresSanitization(tagName: string, attribute: string): boolean {
Expand Down
Loading