fix(core): set Cache-Control: private, no-store on editor toolbar-injected HTML (#1398)#1559
Open
marcusbellamyshaw-cell wants to merge 2 commits into
Conversation
…ected HTML (emdash-cms#1398) The request-context middleware injected the editor toolbar into public HTML for a logged-in editor but, unlike the preview branch, did not set Cache-Control: private, no-store. On a site fronted by a shared cache, an editor merely browsing the public site primed the edge cache with toolbar-bearing HTML that was then served to all anonymous visitors -- leaking the toolbar markup and the fact that a session was active. injectToolbar now sets Cache-Control: private, no-store on the actual-injection path, mirroring the preview branch, so toolbar-bearing (session-specific) responses are never shared-cacheable. Responses where no toolbar is injected (non-HTML, or HTML without a </body>) keep their original cacheability. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 56be105 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
review/needs-review
…elease note Per CONTRIBUTING.md, lead with the observable effect and drop the commit-message title line and internal mechanics. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The request-context middleware injects the editor toolbar into public HTML for a logged-in editor but, unlike the preview branch, did not set
Cache-Control: private, no-store. On a site fronted by a shared cache (Cloudflare, etc.), an editor merely browsing the public site primed the edge cache with toolbar-bearing HTML that was then served to all anonymous visitors — leaking the toolbar markup and the fact that a session was active.injectToolbarnow setsCache-Control: private, no-storeon the actual-injection path, mirroring the preview branch, so toolbar-bearing (session-specific) responses are never shared-cacheable. Responses where no toolbar is injected (non-HTML, or HTML without a</body>) keep their original cacheability.Closes #1398
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (targeted: new + toolbar + cache-hints suites)pnpm formathas been runAI-generated code disclosure