fix: set urlPattern "/{slug}" on the pages collection in starter seeds (#1062)#1575
Open
marcusbellamyshaw-cell wants to merge 1 commit into
Open
Conversation
emdash-cms#1062) The starter and starter-cloudflare templates ship a root `[slug].astro` route for pages, but the seeded pages collection had no `urlPattern`, so the admin "View" link and visual-editing overlay pointed at a URL that didn't match the route. Declaring the pattern aligns the collection with the route the template already provides. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
github-actions
Bot
added
review/needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
starterandstarter-cloudflaretemplates ship a root[slug].astroroute for pages, but the seededpagescollection has nourlPattern. As a result the admin "View" link and the visual-editing overlay resolve to a URL that doesn't match the route the template provides. This declaresurlPattern: "/{slug}"so the collection lines up with the route already present in both templates.Closes #1062
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runtemplates/*are not published packagesAI-generated code disclosure