Skip to content

Kitdiff setup: Rename paths to examples #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalsustr merged 1 commit into from
Dec 3, 2025
Merged

Kitdiff setup: Rename paths to examples #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/accept_snapshots.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
set -eu

# rename the .new.png files to .png
find . -type d -path "*/tests/snapshots*" | while read dir; do
find . -type d -path "./examples/*" | while read dir; do
Copy link
Collaborator

@lucasmerlin lucasmerlin Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think we should do it for both the examples and /tests/snapshots folders, since we might want to add more tests in the future

find "$dir" -type f -name "*.new.png" | while read file; do
mv -f "$file" "${file%.new.png}.png"
done
Expand Down
2 changes: 1 addition & 1 deletion scripts/update_snapshots_from_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ else
fi

# remove any existing .new.png that might have been left behind
find . -type d -path "*/tests/snapshots*" | while read dir; do
find . -type d -path "./examples/*" | while read dir; do
Copy link
Collaborator

@lucasmerlin lucasmerlin Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

find "$dir" -type f -name "*.new.png" | while read file; do
rm "$file"
done
Expand Down
Loading