Allow Plot::link_cursor to accept impl Into<Vec2b>
#66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `link` argument to the `impl Into<Vec2b>` to be consistent with `link_axis`. This makes it slightly cleaner to use.
bircni
approved these changes
Jan 8, 2025
Contributor
bircni
left a comment
bircni
left a comment
There was a problem hiding this comment.
There are more points with the same Vec2b
Could you change these too?
Contributor
Author
|
Done, I think! |
emilk
approved these changes
Jan 29, 2025
emilk
added
enhancement
michalsustr
pushed a commit
that referenced
this pull request
Nov 26, 2025
Updates the `link` argument to the `impl Into<Vec2b>` to be consistent with `link_axis`. This makes it slightly cleaner to use. <!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui_plot/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo f or a new example. * Do NOT open PR:s from your `master` or `main` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! We will review your PR, but our time is limited! --> * [x] I have followed the instructions in the PR template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
linkargument to theimpl Into<Vec2b>to be consistent withlink_axis. This makes it slightly cleaner to use.