Add support for cmake 4.0+ during testing #25974
Conversation
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Is there some command line argument we could instead pass to cmake to tell it not to worry about this?
(I don't love changing these files under third_party as they are supposed to be mostly unmodified upstream files).
Lgtm if its the only way.
JAicewizard
force-pushed
the
bump_cmake_min
branch
from
45d6b88 to
1d5d008
Compare
|
Yes, I force-pushed a change to |
|
Sorry for the commit spam, but this should only overwrite the version for testing now! |
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Nice!
Maybe add a comment in both these location. Something like "Some tests have very old cmake_minimum_version settings which is not supported by cmake 4.2+. Forcing a slighly more recent cmake_minimum_version works around this issue."
| if configure: | ||
| if configure[0] == 'cmake': | ||
| configure = [EMCMAKE] + configure | ||
| configure = [EMCMAKE '-DCMAKE_POLICY_VERSION_MINIMUM=3.5'] + configure |
There was a problem hiding this comment.
| configure = [EMCMAKE '-DCMAKE_POLICY_VERSION_MINIMUM=3.5'] + configure | |
| configure = [EMCMAKE, '-DCMAKE_POLICY_VERSION_MINIMUM=3.5'] + configure |
3 participants
Fixes #25964
Follow-up of #25966
There were some more vendored libs that weren't supported by CMake 4.0.