Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Dec 18, 2025

We don't want the raw exports include things like
Asyncify.instrumentWasmExports or relocateExports. They should be the actual raw exports.

See #25621

We don't want the raw exports include things like
`Asyncify.instrumentWasmExports` or `relocateExports`.  They should be
the actual raw exports.

See emscripten-core#25621
@sbc100 sbc100 requested review from kripken and tlively December 18, 2025 19:15
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test we can write for this?

@inolen
Copy link
Collaborator

inolen commented Dec 18, 2025

It would also be useful to not have this behind the SPLIT_MODULE ifdef (at least for my personal use).

@sbc100
Copy link
Collaborator Author

sbc100 commented Dec 18, 2025

It would also be useful to not have this behind the SPLIT_MODULE ifdef (at least for my personal use).

Sadly that would increase codesize for everyone so we don't want to do that by default if we can help it.

Have you looked into using wasmImport + -sMAIN_MODULE=2 (that latter will inject raw exports that you want into wasmImports on load).

@sbc100
Copy link
Collaborator Author

sbc100 commented Dec 18, 2025

Is there a test we can write for this?

Its a little tricky because for a couple of reasons:

  1. We would need to make the test sensitive to having JS wrapper around the imports.
  2. We would need to make sure the imports we split out have some kind of JS wrapper installed.

I will have a go but if its not easy I might just request that we land this as a "does not regress" change :)

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly either way about testing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants