Hide certain symbols for X360 COFFs

[rjkiv]

This hides any symbol starting with except_data_ automatically if you're working on X360.
In addition, __unwinds are now hidden by default, with the option to show them again added in Arch Settings.

fixes #232

[rjkiv]

update: have spotted __catch symbols as well and have hidden those alongside the __unwinds

[tomsons26]

Wouldnt it be better to handle this via config? #238
Also this would apply to msvc x86 as well not just ppc

[rjkiv]

I'd have to disagree - except_datas aren't actual functions, they're 8 byte structs containing pointers to exception data. Since our decomped code doesn't automatically spawn the same except data structs, I'd argue it's not worth keeping them in the function list window.

As for unwinds and catches....I still think those would be better off automatically hidden - your only real use of matching these 100% would be if you're trying to link, which X360 isn't currently doing. But that said, I'm open to further discussion about this.

[tomsons26]

I'm not arguing against hiding these things, I understood that it's data, I mean i think the ignore lists should be adjustable via the project not hardcoded into objdiff

[encounter]

Are we sure there's no automatic way to detect these? e.g. certain symbol type/metadata

[encounter]

Is this functionally different than clicking "Show hidden symbols" in Diff Options?

[rjkiv]

Functionally, no it is not - I suppose instead of this option we can just bundle in the except_datas and the __unwinds/__catches under the "hidden symbols" umbrella?

[encounter]

Yes, and in fact that's what you're doing with SymbolFlag::Hidden, so it should work already!