Fix armcc symbols always being hidden#364
Merged
Merged
Conversation
Contributor
|
This “fix” feels fairly hacky. The issue doesn’t occur when compiling with Clang or GCC, so it seems specific to this configuration. In my view, this behavior should be gated behind an explicit flag on the units in objdiff.json, allowing projects that need to target Armcc to opt in, while leaving the default behavior unchanged for other architectures. |
Contributor
Author
|
Not sure why you are putting fix in quotes but yeah it's hacky, making it an opt in setting sounds like a good solution |
Owner
|
I agree it's not ideal but I'm okay with this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason armcc always marks global symbols as hidden (referred to as
Linkageby theobjectlibrary) which makes objdiff never display any non-static functions unless the "Show hidden symbols" option is enabled, which is an undesirable workaround because that always adds a lot of noise symbols.This fixes it by never hiding any global symbols in ARM ELF objects. I don't know if this causes any collateral damage in non-armcc ecosystems but armcc only ever marks actual function symbols as global so it works.