Minor corrections after reading and running the notebooks#1
Open
pareal wants to merge 7 commits intoengineersCode:masterfrom
Open
Minor corrections after reading and running the notebooks#1pareal wants to merge 7 commits intoengineersCode:masterfrom
pareal wants to merge 7 commits intoengineersCode:masterfrom
Conversation
Cantera which uses the most accurate equations of state instead of Cantera, which provides exact property values (to within experimental error)
This reverts commit 8f0423f.
Added some explanatory text in heat transfer analysis using numerical quadrature.
Corrected some typos. Added "assuming negligible piston mass" to the piston analysis For an ideal gas, $c_v(T,P) = c_v(T)$ i.e. cv depends only on temperature.
Just added "negleting piston mass" to forces balance on piston analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just read and executed the notebooks.
Exciting stuff, really shows how python and cantera property library can be used to dig deeper into thermodynamics problems using open source tools.
Found and corrected what seemed to be typos.
Found some minor things that appear mistaken or missing.
This is my first pull request, hope I'm not doing anything wrong.
Keep up the good work.