Issue #84 -- emit esl::end on socket::close#86
Open
ssinyagin wants to merge 1 commit intoenglercj:masterfrom
Open
Issue #84 -- emit esl::end on socket::close#86ssinyagin wants to merge 1 commit intoenglercj:masterfrom
ssinyagin wants to merge 1 commit intoenglercj:masterfrom
Conversation
net.Socket emits "end" only on successful closing, but it emits "close" in error conditions as well.
Owner
|
Thanks for tracking this down. Looks like this breaks one of the tests, can you look into why that is please? |
Author
|
seems like you're expecting connection::close while the socket is still alive. With my patch, the close event comes when the socket is done. |
Owner
|
Makes sense, I'm happy to merge this once the tests are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net.Socket emits "end" only on successful closing, but it emits "close" in error conditions as well.