Persist scoring window and voted swaps across validator restarts#17
Open
bitloi wants to merge 3 commits intoentrius:testfrom
Open
Persist scoring window and voted swaps across validator restarts#17bitloi wants to merge 3 commits intoentrius:testfrom
bitloi wants to merge 3 commits intoentrius:testfrom
Conversation
Author
|
@LandynDev @anderdc Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Summary
ScoringWindowStorefor atomic JSON persistence of the scoring window and voted set, following the existing tmp-file-then-rename pattern used bySwapFulfiller._save_sent_cache.SwapTrackerload oninitialize(), persist on swap resolution, window pruning, andmark_voted()._resolved_blockhelper by sharing a singleresolved_block()from the store module.<neuron.full_path>/scoring_window.json.Design
Persistence hooks at every state mutation point only. The store is optional (
Nonedisables persistence) so existing tests and standalone usage remain unaffected. On cold start, stale voted IDs are pruned against the active swap set to prevent unbounded growth.Test plan
ruff check allways/validator/scoring_store.py allways/validator/swap_tracker.py neurons/validator.pypassespython3 -m pytest tests/test_rate.py tests/test_chains.py -q --tb=shortpassespython3 -m pytest tests/test_scoring_store.py -q --tb=shortpasses (local)SCORING_WINDOW_BLOCKSpruned on load