Skip to content

Fix #206: delete mirrored issues on issues.deleted webhook #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marktech0813 wants to merge 1 commit into from
Closed

Fix #206: delete mirrored issues on issues.deleted webhook #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/das/src/webhook/handlers/issue.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,19 @@ export class IssueHandler {
// Skip pull request events delivered as issue events
if (issue.pull_request) return;

// Mirror CommentHandler / ReviewCommentHandler: drop rows on delete so
// miners APIs never keep serving a GitHub-deleted issue.
if (payload.action === "deleted") {
await this.issueRepo.delete({
repoFullName,
issueNumber: issue.number,
});
await this.repoRepo.update(repoFullName, {
lastEventAt: new Date().toISOString(),
});
return;
}

const issueState = issue.state.toUpperCase();
const data: Partial<Issue> = {
repoFullName,
Expand Down