Skip to content

Fix/leaderboard sidebar duplicate key#124

Open
tmimmanuel wants to merge 10 commits intoentrius:testfrom
tmimmanuel:fix/leaderboard-sidebar-duplicate-key
Open

Fix/leaderboard sidebar duplicate key#124
tmimmanuel wants to merge 10 commits intoentrius:testfrom
tmimmanuel:fix/leaderboard-sidebar-duplicate-key

Conversation

@tmimmanuel
Copy link
Copy Markdown

Summary

  • Fix React key collision in LeaderboardSidebar causing duplicate/ghost entries when switching between Top Earners and Most Active tabs
  • Changed list key from miner.hotkey (can be shared/N/A) to miner.githubId (unique per row)

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Screenshots

video.mp4

spider-yamet
madelyngamble2

(miner, i) => (
<LeaderboardRow
key={miner.hotkey}
key={miner.githubId || miner.hotkey}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I'd prefer the keys to only have 1 value, would it be better to just use githubId in both the cases you updated?

@tmimmanuel
Copy link
Copy Markdown
Author

@anderdc I fixed.
It only uses miner.githubId
It passes lint check.
Please review.

@tmimmanuel tmimmanuel requested a review from anderdc April 9, 2026 23:37
eureka0928 and others added 6 commits April 10, 2026 11:45
…igible

- Dashboard models: remove tier, currentTier, qualifiedUniqueReposCount,
  rawCredibility, credibilityScalar, repositoryUniquenessMultiplier,
  all bronze/silver/gold tier stats fields
- Add isEligible and credibility to MinerEvaluation
- Delete Predictions model and API
- Remove TierConfig from Configurations model and API
- Update leaderboard MinerStats type
Strip Bronze/Silver/Gold tier system across 51 files (~4950 lines removed).
Replace with flat isEligible boolean, update dynamic PR threshold from 500
to 300, revamp onboard Getting Started with 7-step inline setup guide
matching docs, remove Roadmap and FAQ tabs from onboard page.
🤖 Automated formatting by GitHub Actions
…ting

Replace dangerouslySetInnerHTML with ReactMarkdown + rehypeRaw for safe
rendering of GitHub-provided HTML in issue bodies and PR conversations.
Add missing CSS for lists, paragraphs, tables, and other elements that
MUI CssBaseline resets.

- Use ReactMarkdown with remarkGfm and rehypeRaw (same as ReadmeViewer)
- Add styles for ul/ol, li, p, table, hr, task checkboxes
- Fix pre/code nesting so inline code inside blocks renders correctly
- Left-align conversation panels to match GitHub layout
- Fix fallback text rendering (HTML em instead of markdown asterisks)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@tmimmanuel tmimmanuel force-pushed the fix/leaderboard-sidebar-duplicate-key branch from 7aa3343 to 347b793 Compare April 10, 2026 19:10
@tmimmanuel
Copy link
Copy Markdown
Author

@anderdc Please review my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants