fix: handle null author field for deleted GitHub accounts#381
Closed
Grizouforever wants to merge 1 commit intoentrius:testfrom
Closed
fix: handle null author field for deleted GitHub accounts#381Grizouforever wants to merge 1 commit intoentrius:testfrom
Grizouforever wants to merge 1 commit intoentrius:testfrom
Conversation
Use safe null checks for pr_raw['author'] to avoid KeyError/TypeError
when a PR author's account has been deleted on GitHub. Replace direct
dict access with (pr_raw.get('author') or {}).get('login', 'ghost')
in both classes.py and github_api_tools.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr_raw['author']['login']access with(pr_raw.get('author') or {}).get('login', 'ghost')inclasses.pyandgithub_api_tools.pyKeyError/TypeErrorcrashes when a PR author's GitHub account has been deletedRelated Issues
Fixes #366
Type of Change
Testing
Checklist
cc @anderdc @LandynDev for review