fix: guard handle_pat_check against ValueError for unregistered hotkeys#383
Closed
Grizouforever wants to merge 1 commit intoentrius:testfrom
Closed
fix: guard handle_pat_check against ValueError for unregistered hotkeys#383Grizouforever wants to merge 1 commit intoentrius:testfrom
Grizouforever wants to merge 1 commit intoentrius:testfrom
Conversation
handle_pat_check called metagraph.hotkeys.index(hotkey) without first checking whether the hotkey is registered, raising an uncaught ValueError when an unregistered caller hits the endpoint. Add an early-exit guard that mirrors the blacklist handler, and add a test for this path.
Collaborator
|
The blacklist function runs before the handler. If the hotkey isn't registered, the synapse gets rejected at the blacklist layer and handle_pat_check is never called. Thus this bug/issue never happens in production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_pat_checkinpat_handler.pymetagraph.hotkeys.index(hotkey)raises an uncaughtValueErrorwhen an unregistered caller reaches the handlertest_unregistered_hotkey_returns_no_patRelated Issues
Fixes #376
Type of Change
Testing
Checklist
cc @anderdc @LandynDev for review