fix: assign evaluation_timestamp before stale cleanup#384
Open
Grizouforever wants to merge 1 commit intoentrius:testfrom
Open
fix: assign evaluation_timestamp before stale cleanup#384Grizouforever wants to merge 1 commit intoentrius:testfrom
Grizouforever wants to merge 1 commit intoentrius:testfrom
Conversation
cleanup_stale_miner_data used evaluation.evaluation_timestamp as a SQL parameter before it was ever set, passing None and leaving stale rows uncleared. Assign evaluation_timestamp = datetime.now(timezone.utc) at the start of the method so the timestamp is always available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evaluation.evaluation_timestamp = datetime.now(timezone.utc)at the start ofcleanup_stale_miner_datainrepository.pyNone, preventing stale rows from being correctly cleaned upfrom datetime import datetime, timezoneimportRelated Issues
Fixes #378
Type of Change
Testing
Checklist
cc @anderdc @LandynDev for review