fix: preserve github_id when penalizing miners sharing GitHub accounts#385
Open
Grizouforever wants to merge 1 commit intoentrius:testfrom
Open
fix: preserve github_id when penalizing miners sharing GitHub accounts#385Grizouforever wants to merge 1 commit intoentrius:testfrom
Grizouforever wants to merge 1 commit intoentrius:testfrom
Conversation
When detect_and_penalize_miners_sharing_github replaced a MinerEvaluation with a zeroed-out copy, it only kept uid and hotkey, losing github_id. Downstream storage and dedup logic depends on github_id being set, so a None/default '0' value could allow stale data to persist. Pass the original github_id to the replacement MinerEvaluation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github_id=miner_evaluations[uid].github_idto the replacementMinerEvaluationininspections.pygithub_id, causing downstream storage and dedup logic to treat the miner as if they had no GitHub account ('0')Related Issues
Fixes #375 (or related)
Type of Change
Testing
Checklist
cc @anderdc @LandynDev for review