fix: exclude deleted files from code_density calculation#392
Open
t7929375-eng wants to merge 1 commit intoentrius:testfrom
Open
fix: exclude deleted files from code_density calculation#392t7929375-eng wants to merge 1 commit intoentrius:testfrom
t7929375-eng wants to merge 1 commit intoentrius:testfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a PR deletes files, the deleted files are correctly scored at 0 (
scoring_method='skipped') intree_sitter_scoring.py, but theirtotal_lines(set tofile.deletions) are still included in thetotal_linessum inscoring.py:172.Since
code_density = token_score / total_lines, deleted files inflate the denominator without contributing to the numerator, artificially deflating code_density and reducing the base_score for all miners whose PRs include file deletions.This fix filters out skipped (deleted) files from the
total_linescalculation so that code_density accurately reflects only the scored content.Example: A PR with 50 lines of dense code (token_score=80) that also removes a 200-line file would get
code_density = 80/250 = 0.32instead of the correct80/50 = 1.6— a 5x penalty.Type of Change
Testing
ruff checkpassespyrightpassesChecklist
cc @anderdc @LandynDev