fix: escape special characters in GraphQL file path expressions#393
Open
t7929375-eng wants to merge 1 commit intoentrius:testfrom
Open
fix: escape special characters in GraphQL file path expressions#393t7929375-eng wants to merge 1 commit intoentrius:testfrom
t7929375-eng wants to merge 1 commit intoentrius:testfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File paths containing double quotes or backslashes are interpolated directly into GraphQL
expressionfields (e.g.{sha}:{path}), producing syntactically invalid queries. This causes_fetch_file_contents_batchand_fetch_file_contents_with_base_batchto silently return empty results for affected files, giving those PRs a score of 0.Adds a
_escape_graphql_stringhelper and applies it to all three path interpolation sites:_fetch_file_contents_batch(head expression)_fetch_file_contents_with_base_batch(base expression)_fetch_file_contents_with_base_batch(head expression)Related Issues
Fixes #368
Type of Change
Testing
Checklist
cc @anderdc @LandynDev