Fix Accessibility Violations for Navigation and Footer Elements#541
Open
huangkevin-apr wants to merge 1 commit intoenvoyproxy:mainfrom
Open
Fix Accessibility Violations for Navigation and Footer Elements#541huangkevin-apr wants to merge 1 commit intoenvoyproxy:mainfrom
huangkevin-apr wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for envoy-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: huangkevin-apr <huangkevinapr@outlook.com>
605ede2 to
8b47ae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves 2 accessibility violations detected by the IBM Equal Access Accessibility Checker related to navigation landmarks lacking unique labels. The fix ensures multiple
<nav><footer>elements on the same page can be distinguished by screen reader users.Problem
The IBM A11Y Checker identified the following issues:


Why is this important?
When there are multiple elements with role "nav" on a page, they must have unique labels that clearly describe their purpose. This helps people who use assistive technologies to quickly understand and navigate to each navigation region.
Solution
Implemented a flexible labeling system using Django/Jinja2 template variables to provide unique aria-label attributes for each navigation instance.
Files Changed:
site/theme/templates/nav.html- Added aria-label with default valuesite/theme/templates/footer.html- Provided custom label for footer instanceBenefits