Closed
bazel: split wee8 prebuilts by stdlib and select the correct archive for gcc#5051
Conversation
✅ Deploy Preview for nifty-bassi-e26446 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Copilot Request
bazel: split wee8 prebuilts by stdlib and select the correct archive for gcc
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//v8:wee8_smoke_testwas consuming a libc++-built prebuilt archive on gcc/libstdc++ legs because wee8 prebuilts were keyed only by cpu/os. This changes wee8 packaging and selection to treat stdlib as part of the artifact identity, while keeping the existing libc++ artifact name stable.What changes
//v8:wee8_package_linux_x86_64now produces both x86_64 variants in a single build via a Starlark transition:v8-wee8-<version>-linux-x86_64.tar.xz(existing libc++ artifact, preserved)v8-wee8-<version>-linux-x86_64-libstdcxx.tar.xzaarch64remains libc++ only and keeps the existing artifact name.Packaging / transition
bazel/v8/wee8_package.bzlthat flips//compile:use_gcc_toolchainfor the libstdc++ package edge.//command_line_option:extra_toolchains, so the gcc toolchains are selected within the transitioned configuration; no extra CI matrix leg is needed.Prebuilt repository layout
setup_wee8_prebuiltnow instantiates:@wee8_prebuilt_x86_64@wee8_prebuilt_x86_64_libstdcxx@wee8_prebuilt_aarch64VERSIONS["wee8_sha256"]and the release update logic are keyed by both arch and stdlib.lib/libwee8.a; the repo instead exposes an explicitly incompatible target with a clear message.Consumer selection
bazel/v8/BUILDnow defines//v8:wee8locally and selects on both platform and//compile:use_gcc_toolchain.--config=gccresolves to the libstdc++ prebuiltModule / workspace wiring
WORKSPACEandMODULE.bazelso the same prebuilt selection model exists in workspace and bzlmod modes.CI / release metadata
package-v8artifact globs to upload the new stdlib-qualified tarball alongside the existing libc++ artifact.--experimental_ui_max_stdouterr_bytesin the Bazel CI invocation for diagnosable link failures.Example of the new selection shape: