Remove DataField accessor#377
Merged
Merged
Conversation
7f14da1 to
1f77740
Compare
90c9a77 to
851d298
Compare
851d298 to
7603997
Compare
There was a problem hiding this comment.
Pull request overview
Removes the DataField key accessor and standardizes key mapping to only reference meta-table (primary key) columns, simplifying transform key handling across the meta/compute layers.
Changes:
- Removed
DataField/FieldAccessortypes and updatedInputSpec.keys/ComputeInput.keystodict[str, str]. - Simplified SQL meta aggregation logic to only use meta-table primary keys (no data-table joins for key extraction).
- Updated tests and the key-mapping design doc to reflect the new “keys must be PK/meta columns” model.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_meta_transform_keys.py | Updates schema + key mapping usage to no longer rely on DataField. |
| design-docs/2025-12-key-mapping.md | Updates design doc examples/constraints to remove DataField and require PK-based keys. |
| datapipe/types.py | Removes DataField and narrows InputSpec.keys typing to dict[str, str]. |
| datapipe/meta/sql_meta.py | Removes DataField handling and data-table join logic from get_agg_cte. |
| datapipe/meta/base.py | Updates transform_idx_to_table_idx typing and mapping semantics to dict[str, str]. |
| datapipe/compute.py | Updates ComputeInput.keys typing and removes DataField-based schema logic. |
| CHANGELOG.md | Removes mention of adding DataField (needs an explicit “removed/breaking change” note). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.