Significantly improved Progress component#3
Open
Gingerbeard5773 wants to merge 3 commits intoeps0003:masterfrom
Open
Significantly improved Progress component#3Gingerbeard5773 wants to merge 3 commits intoeps0003:masterfrom
Gingerbeard5773 wants to merge 3 commits intoeps0003:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts in a proper implementation of progress that allows for better customization and directionality.
color is self explanatory- the progress pane can be colored unlike before. still no way to color the background pane however.
fill direction is what this pr is really about: it allows the progress fill to be set in any direction. from top to bottom or right to left and vice versa. Previously StandardHorizontalProgress was using the engine function DrawProgressBar- which was flawed as it could only go from left to right.
*As a result of added fill direction-
StandardHorizontalProgressis replaced withStandardProgress, and there is no more need to add aStandardVerticalProgresswhich was supposedly planned