feat: add MultiHookRouter for composable per-job hooks#21
Open
ariessa wants to merge 1 commit intoerc-8183:mainfrom
Open
feat: add MultiHookRouter for composable per-job hooks#21ariessa wants to merge 1 commit intoerc-8183:mainfrom
ariessa wants to merge 1 commit intoerc-8183:mainfrom
Conversation
…ate acp submodule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Each ERC-8183 job can only attach one hook. Jobs needing multiple concerns (escrow, privacy, reputation) must cram everything into a single monolithic contract — hard to build, hard to audit, impossible to reuse.
Additionally, BaseACPHook's setBudget selector still used the old 3-param signature
setBudget(uint256,uint256,bytes)while AgenticCommerce expectssetBudget(uint256,address,uint256,bytes). This meant _preSetBudget and _postSetBudget callbacks silently never fired.Solution
tokenparameter